Show available updates in Dashboard #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaawong
force-pushed
the
miawong/sc-108146/show-on-the-dashboard-that-there-are-newly
branch
2 times, most recently
from
7faeb90 to
92af5c3
Compare
sgalsaleh
reviewed
Aug 22, 2024
| @@ -110,6 +114,11 @@ type State = { | |||
| versionToDeploy: Version | null; | |||
| viewLogsErrMsg: string; | |||
| yamlErrorDetails: string[]; | |||
| upgradeService: { | |||
There was a problem hiding this comment.
there's no upgrade service here though, no?
sgalsaleh
reviewed
Aug 22, 2024
There was a problem hiding this comment.
i see a lot of duplicate logic from the available update row in the version history page. wonder if we can reuse some of that.
miaawong
force-pushed
the
miawong/sc-108146/show-on-the-dashboard-that-there-are-newly
branch
from
92af5c3 to
2b62c65
Compare
sgalsaleh
approved these changes
Aug 23, 2024
miaawong
deleted the
miawong/sc-108146/show-on-the-dashboard-that-there-are-newly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
https://app.shortcut.com/replicated/story/108146/show-on-the-dashboard-that-there-are-newly-available-versions#activity-110729
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?